256 Star 932 Fork 106

MindSpore / mindarmour

 / 详情

Suggestions for adding OWNERS files

TODO
Task-Tracking
Opened this issue  
2021-06-30 11:32
name about labels
Bug Report Use this template for reporting a bug kind/task

In order to make the new robot better support the code review process, we recommend adding the OWNERS file.
OWNERS files are used to specify responsibilities for different parts of the code base. Use them to assign the reviewer and approver roles used in our two-phase code review process.

The velocity of a project that uses code review is limited by the number of people capable of reviewing code. The quality of a person's code review is limited by their familiarity with the code under review. Our goal is to address both of these concerns through the prudent use and maintenance of OWNERS files.

OWNERS files are in YAML format and support the following keys:

  • approvers: a list of gitee usernames or aliases that can /approve a PR
  • reviewers: a list of gitee usernames or aliases that are good candidates to /lgtm a PR
  • options: a map of options for how to interpret this OWNERS file, currently only one:
    • no_parent_owners: defaults to false if not present; if true, exclude parent OWNERS files. Allows the use case where a/deep/nested/OWNERS file prevents a/OWNERS file from having any effect on a/deep/nested/bit/of/code

The above keys constitute a simple OWNERS configuration.

A typical OWNERS file looks like:

approvers:
  - alice
  - bob    
reviewers:
  - carol  

OWNERS files should be regularly maintained.
We should strive to:

  • grow the number of OWNERS files
  • add new people to OWNERS files
  • ensure OWNERS files only contain organization members
  • ensure OWNERS files only contain people are actively contributing to or reviewing the code they own
  • remove inactive people from OWNERS files

Comments (12)

xwzQmxx createdBug-Report
xwzQmxx set related repository to MindSpore/mindarmour
xwzQmxx changed description
xwzQmxx changed issue type from Bug-Report to Task-Tracking
xwzQmxx changed description
fangwenyi changed issue state from TODO to ACCEPTED
jxl changed issue state from ACCEPTED to DONE
Se7en changed issue state from DONE to ACCEPTED
Se7en changed issue state from ACCEPTED to DONE
Se7en changed issue state from DONE to ACCEPTED
Se7en changed issue state from ACCEPTED to DONE
Se7en changed issue state from DONE to ACCEPTED
Expand operation logs

@xwzQmxx you can't close an issue unless the issue has link pull requests.

jxl changed issue state from ACCEPTED to DONE
Se7en changed issue state from DONE to ACCEPTED

@jxl you can't close an issue unless the issue has link pull requests.

jxl changed issue state from ACCEPTED to DONE
Se7en changed issue state from DONE to ACCEPTED
Se7en changed issue state from ACCEPTED to DONE
Se7en changed issue state from DONE to ACCEPTED

@Se7en you can't close an issue unless the issue has link pull requests.

jxl changed issue state from ACCEPTED to TODO
jxl changed issue state from TODO to DONE
Se7en changed issue state from DONE to TODO

@jxl you can't close an issue unless the issue has link pull requests.

jxl changed issue state from TODO to DONE
Se7en changed issue state from DONE to TODO

@jxl you can't close an issue unless the issue has link pull requests.

@jxl you can't close an issue unless the issue has link pull requests.

Se7en changed issue state from TODO to DONE
i-robot changed issue state from DONE to TODO

@Se7en you can't close an issue unless the issue has link pull requests.

jxl changed issue state from TODO to DONE
jxl changed issue state from DONE to TODO

@jxl you can't close an issue unless the issue has link pull requests.

jxl changed issue state from TODO to DONE
i-robot changed issue state from DONE to TODO

@jxl you can't close an issue unless the issue has link pull requests.

i-robot changed issue state from TODO to DONE
jxl changed issue state from DONE to TODO
jxl changed issue state from TODO to DONE
jxl changed issue state from DONE to TODO

Sign in to comment

Status
Assignees
Projects
Milestones
Pull Requests
Successfully merging a pull request will close this issue.
Branches
Planed to start   -   Planed to end
-
Top level
Priority
Duration (hours)
参与者(3)
Python
1
https://gitee.com/mindspore/mindarmour.git
git@gitee.com:mindspore/mindarmour.git
mindspore
mindarmour
mindarmour

Search

53164aa7 5694891 3bd8fe86 5694891